Remove deprecated -ttl flag from spire server cli #5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the deprecated `-ttl` flag from `spire entry create` and `spire entry update`. Docs are also updated. See discussion in spiffe#5254 Signed-off-by: Marcel Levy <[email protected]>
heymarcel
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
|
can you update ITs that are using -ttl and replace that with x509SVIDTTL or jwtSVIDTTL depending the case? |
|
@MarcosDY Sorry about missing the integration tests. I have them working now, but I notice the Windows unit tests are still failing. Is that expected, or am I missing something? https://github.com/heymarcel/spire/actions/runs/10815947896/job/30006064864 |
|
Thanks for taking care of this! |
|
Thanks! I've got that running now as well. |
|
Looks good but, one last thing, |
Signed-off-by: Marcel Levy <[email protected]>
Signed-off-by: Marcel Levy <[email protected]>
MarcosDY
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the deprecated
-ttlflag fromspire entry createandspire entry update.See discussion in issue #5254.
Pull Request check list
Affected functionality
This commit removes the deprecated
-ttlflag fromspire entry createandspire entry update.Description of change
As per the issue referenced above:
Which issue this PR fixes
fixes#5254